search

adamlwgriffiths / cyglfw3

Cython bindings for GLFW3
Other
20 stars 6 forks source link

Modifed version import to be Python 3 compatible #17

Closed infowantstobeseen closed 8 years ago

infowantstobeseen commented 9 years ago

Quick modification to allow cyglfw3 to be built on Python 3 (see Issue #14). Doesn't address clever things like automunging Python unicode strings to Cython byte strings or such (which would need to be one in the generation scripts), but does appear to work on OS X at least.

adamlwgriffiths commented 9 years ago

Awesome, thanks for the addition. One point, open should be in a context manager statement (with open(...)) or have an explicit close statement. I know it's only the setup script, but it's still good to do.

infowantstobeseen commented 8 years ago

And done. Works on my Python 3.4.

adamlwgriffiths commented 8 years ago

Sweet, thanks!