adammcarth / react-native-segmented-picker

Selection picker wheel with multi-column support and optional native dependencies.
MIT License
96 stars 31 forks source link

Change font size? #36

Open williamflaherty opened 3 years ago

williamflaherty commented 3 years ago

Hi!

I see you haven't worked on this in a while but I'm wondering if it would be possible to add a way to change the font size of the labels. I tried styling it a few way and dove into the code but I'm too much of a react-native/swift novice to understand what I'd update to make it either a prop or style option.

I toyed with it a bit, updating the label font size in the PickerView.swift file and I see a font size style in SegmentedPickerStyles but I couldn't figure out how I would use/update those values in code if it's already an option, either.

As an aside, thanks for making this!

adammcarth commented 3 years ago

Hey mate.

This sounds like a pretty simple feature request to implement, I might be able to give it a crack this weekend! Can I just confirm what you actually mean by changing the label font size though?

Are you talking about the labels of the selections, or the "Done" button?

Also, would you happen to have have a design or a screenshot of what look you're going for? I'm just curious as to why you'd want to change the label sizing around too much... I was kind of under the impression that on iOS there was generally a "standard" font size for the picker.

williamflaherty commented 3 years ago

Thanks for getting back to me! By label I meant the selections font size. I’m using some Unicode values that represent fractions and they show up kinda small and I haven’t found a sub but I was looking for something more legible like this: AA3E861D-6ACF-4AEC-99DD-EE46E588D223

HadasKedem commented 2 years ago

hi, can you please add an option to change all style? this looks very simple and not at all readable for users