search

adammck / ruby-icloud

Ruby library to access Apple's iCloud (Just reminders, for now)
MIT License
126 stars 17 forks source link

Use with json instead of json_pure #6

Closed troy closed 10 years ago

troy commented 10 years ago

Any idea whether this actually relies on json_pure specifically, or just any working implementation of JSON.parse and Hash.to_json (like would be provided by json)? The gemspec depends on json_pure, which conflicts with another JSON implementation I'm using (more).

From this commit, it looks like this was an attempt to not require native code.

And I totally understand if you don't have time or interest to answer this :) Thanks either way :)

adammck commented 10 years ago

No, I'm pretty sure it works fine with the regular json gem. I switched to json_pure back when OSX shipped with Ruby 1.8, which didn't include a JSON parser. Now it ships with Ruby 2.0, so this dependency can probably be removed altogether.

troy commented 10 years ago

Great, thanks @adammck.

troy commented 10 years ago

Confirmed, works fine.