search

adammw / node-cec

libcec bindings for node.js
MIT License
12 stars 4 forks source link

Transmit: command listener and get/set functions #3

Open rooi opened 8 years ago

rooi commented 8 years ago

I'm working on a homebridge-cec plugin to use it with Apple's homekit. I'f included a command listener and get power, get/set hdmi port functions

adammw commented 8 years ago

thanks for the PR @rooi! sorry it's been sitting so long, been distracted with other things and haven't had a device to test on for a while.

i've added some comments which will need to be fixed before merging, and just generally i think some of the style needs updating, ie. 2 space indentation, remove commented out code etc. but most of it (the addition of command events and power state) seems sensible.

I haven't seen nan before, seems handy given the speed at which node/v8 is updated and that the project probably no longer compiles on any recent version, although it'll take some time to get my head around.

rooi commented 8 years ago

Hi @adammw,

No problem. It has been a while for me a well. I've been trying to get your node-cec to work using nodejs 4.0 but had no succes. I did find another node-cec https://github.com/patlux/node-cec It seems to work under node-cec but is not complete. Which do you think is easier to use?

I had used your node-cec version (thanks for sharing!) for a homebridge-cec plugin to allow controlling my tv using apple's homekit through siri. Now I switched to nodejs 4.0, this plugin does not work any longer but I'd like to get it working again.

Please note that I'm no nodejs, coffee script or libcec expert ;)