Closed ChrisCarini closed 12 months ago
Hi @adamoutler - I have a subsequent branch that improves the script to help detect when people have not disabled 'protected mode' when running this add-on. I'd like a review on this PR first, since the second change is based upon this one.
Looks good. I think we just need some way to detect Protection Mode or to explicitly state it.
@adamoutler 🎉 I present https://github.com/adamoutler/HassOSConfigurator/pull/33 :D (I had this as a draft PR in my fork, but am now presenting it against the upstream repo (your repo). Please review when you have a moment.
Testing Done
Tested with 'protected mode' enabled (Result: ✅ Test successful!)
Note: I know this state is undesired, however I intentional did so to cause checks in the code to be run.
Tested with 'protection mode' disabled; key not yet written (Result: ✅ Test successful!)
Tested with 'protection mode' disabled; key already written (Result: ✅ Test successful!)
Note: Tested in this state to ensure check for 'key already exists' to be invoked.