adampash / Music-Plus-for-Google-Music

Music Plus adds lots of cool stuff to Google Music.
https://chrome.google.com/webstore/detail/music-plus-for-google-pla/ipfnecmlncaiipncipkgijboddcdmego?hl=en-US
93 stars 14 forks source link

Local Storage is written for current tab url #12

Open antonpiatek opened 11 years ago

antonpiatek commented 11 years ago

Using the plugin on a random tab causes Local Storage to be written to under the URL for that tab's page. This can cause the page on that tab to break, as suddenly it has local storage data which it did not write and does not know how to parse. It is really bad practice to have a plugin write to local storage for any arbitrary tab - if you need local storage, can you not store it for a specific url - i.e. the url of this github page or something?