adampmoss / CreareSEO

A free SEO extension for Magento 1
GNU General Public License v2.0
151 stars 72 forks source link

removed useless condition #120

Closed sprankhub closed 6 years ago

sprankhub commented 6 years ago

I removed the condition !Mage::getStoreConfig('product_use_categories')) and unified the two if s into one. Why can we remove the condition?

  1. The condition is currently useless, because it checks the wrong path. It would have to check catalog/seo/product_use_categories, so that it works. Currently, it always returns null, so that the condition is always evaluated to true.
  2. The condition is counter-intuitive. If I enable the option catalog/seo/product_canonical_tag (which is disabled by default!) then I want the redirect to happen. No matter which other settings I made.