search

adamqqqplay / dota2ai

Ranked Matchmaking AI: An improved Dota2 AI based on Valve's default AI. Has more than 3 million subscribers on Steam.
http://steamcommunity.com/sharedfiles/filedetails/?id=855965029
GNU General Public License v3.0
310 stars 85 forks source link

Partially fix Brewmaster's void spirit / brewling #101

Closed JoshdanG closed 1 year ago

JoshdanG commented 1 year ago

Void brewling will now move and attack Using Astral Pull does not seem to be supported by the Bot API

Also removes old abilities (Corrosive Haze, Drunken Brawler, Thunder Clap) Brewlings no longer gain these abilities from aghs

Illusions go roughly in the direction they decide instead of totally random

Minor reorganization to remove duplicate code

Partially fixes #91

JoshdanG commented 1 year ago

Thanks for your work! I have a small suggestion: the commit information could be divided into sections, which can be easily read by other developers.

Will do. Mashing together a combination multiple refactor and then logical changes definitely made this harder to review than necessary.

adamqqqplay commented 1 year ago

Thanks for your work! I have a small suggestion: the commit information could be divided into sections, which can be easily read by other developers.

Will do. Mashing together a combination multiple refactor and then logical changes definitely made this harder to review than necessary.

Thanks for your understanding. But maybe I didn't make it clear before, in addition to submitting multiple separate commits, you could also describe changes in multiple points in one commit. Just like the commit information I modified on the master branch.

The commit style of each project may be different, but they all have something in common. For further understanding, please refer to: https://reflectoring.io/meaningful-commit-messages/

JoshdanG commented 1 year ago

Thanks for your understanding. But maybe I didn't make it clear before, in addition to submitting multiple separate commits, you could also describe changes in multiple points in one commit. Just like the commit information I modified on the master branch.

The commit style of each project may be different, but they all have something in common. For further understanding, please refer to: https://reflectoring.io/meaningful-commit-messages/

I did get a bit confused there. I think I am separating my commit messages into several chunks (separated by empty lines), but I will number them to make that clearer and consistent with the rest of the project.