Remove side shop check when selling items

[JoshdanG]

The side shop no longer exists, and DistanceFromSideShop() always returns a negative number, causing the check to always pass.

[adamqqqplay]

Thanks for your contribution! I would like to ask what behavioral problems of the bot will this PR solve?

[JoshdanG]

This doesn't change any noticeable behavior. I'm experimenting with changes to deal with bots getting full inventories and stuck at the secret shop. When I added logging to that block it was constantly firing. I thought I'd try a PR with a clean fix for that before introducing changes that are more subjective.

On Sat, May 13, 2023 at 11:55 PM AdamQQQ @.***> wrote:

Thanks for your contribution! I would like to ask what behavioral problems of the bot will this PR solve?

— Reply to this email directly, view it on GitHub https://github.com/adamqqqplay/dota2ai/pull/84#issuecomment-1546823884, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU5XMQY7D6ZEJSDGDWLGWLXGB6WFANCNFSM6AAAAAAYAJAOFQ . You are receiving this because you authored the thread.Message ID: @.***>

[adamqqqplay]

This doesn't change any noticeable behavior. I'm experimenting with changes to deal with bots getting full inventories and stuck at the secret shop. When I added logging to that block it was constantly firing. I thought I'd try a PR with a clean fix for that before introducing changes that are more subjective. … On Sat, May 13, 2023 at 11:55 PM AdamQQQ @.> wrote: Thanks for your contribution! I would like to ask what behavioral problems of the bot will this PR solve? — Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU5XMQY7D6ZEJSDGDWLGWLXGB6WFANCNFSM6AAAAAAYAJAOFQ . You are receiving this because you authored the thread.Message ID: @.>

Thanks, I will merge this soon. And your follow-up fixes are welcome.

[adamqqqplay]

@JoshdanG I think the latest branch has fixed the problem of stuck in the secret shop, please take a look.