Improved item purchasing system to sell items when inventory is full

adamqqqplay / dota2ai

Ranked Matchmaking AI: An improved Dota2 AI based on Valve's default AI. Has more than 3 million subscribers on Steam.

http://steamcommunity.com/sharedfiles/filedetails/?id=855965029

GNU General Public License v3.0

320 stars 86 forks source link

Improved item purchasing system to sell items when inventory is full #99

Closed JoshdanG closed 1 year ago

JoshdanG commented 1 year ago

Improves selling when inventory full:

larger list of items sold
sells one item at a time
sells regardless of time or level
avoids selling parts of a recipe in progress
only sells items in inventory (not stash)
considers full with 9 items rather than 8
only sells within valid range (450) of fountain

Performance changes (unmeasured):

checks only when possible to sell
waits one second before re-checking

Removes .mira file that complicated things with limited benefit

JoshdanG commented 1 year ago

I wanted to ask if it would be okay to remove the ItemPurchaseSystem.mira file and just work directly with the .lua file. This is much simpler for testing, code tools, etc. and the benefits of .mira seem very minor.

If so, there are some comments that should probably be brought over.

If not, then I will edit the .mira file and compile to .lua.

adamqqqplay commented 1 year ago

I wanted to ask if it would be okay to remove the ItemPurchaseSystem.mira file and just work directly with the .lua file. This is much simpler for testing, code tools, etc. and the benefits of .mira seem very minor.

If so, there are some comments that should probably be brought over.

If not, then I will edit the .mira file and compile to .lua.

@JoshdanG Sure, you could remove the mira files. Currently, we are not using mira complier.

Thanks for your work.