Task list 166 - Githubissues

adamralph / bau

The C# task runner

MIT License

152 stars 17 forks source link

Task list 166 #203

Closed aarondandy closed 9 years ago

aarondandy commented 9 years ago

closes #166 closes #65

Adds various plain text task listings as well as a JSON task listing.

NOTE: commit b2bb40a is unrelated to the task but was an important fix to allow me to develop this functionality as the tests were getting annoying without it.

adamralph commented 9 years ago

Thanks @aarondandy! Does this also close #65?

adamralph commented 9 years ago

@aarondandy I've finished looking though the implementation changes and made a couple of comments. The rest looks fine.

I'll take a look at the test changes later.

adamralph commented 9 years ago

@aarondandy I've finished my review of the tests, just some minor comments.

aarondandy commented 9 years ago

[x] Arguments should not create task list writer, just communicate the options.
[x] Make sure all test descriptions match what is actually happening.
[x] TaskListWriter should be internal
[x] Add explicit tests to make sure stuff that should be missing is actually missing
[x] Full task listing should show descriptions. Only tasks with descriptions should contribute to the indentation calculation.

aarondandy commented 9 years ago

I have made changes based on your feedback.

adamralph commented 9 years ago

Great, thanks! I'll take a look ASAP.

eatdrinksleepcode commented 9 years ago

Any update on this? I mostly just want the change to the acceptance tests that prevents the dialog from popping up. If this PR is still going to take some time, I can submit that separately.

adamralph commented 9 years ago

I just haven't found time to check it yet. Feel free to send a PR in the meantime. I'm guessing that will be a one liner.

aarondandy commented 9 years ago

This can be rebased or manually merged if there is a conflict with that file. Not really sure of the best way to handle this with github PRs. I guess just negate the commit? Squash and/or force push?

eatdrinksleepcode commented 9 years ago

I usually rebase/squash and then force push. GitHub will automatically update the PR.

On Jun 26, 2015, at 10:54 AM, Aaron Dandy notifications@github.com wrote:

This can be rebased or manually merged if there is a conflict with that file. Not really sure of the best way to handle this with github PRs. I guess just negate the commit? Squash and/or force push?

— Reply to this email directly or view it on GitHub.

aarondandy commented 9 years ago

If your PR wins I'll remove it from mine. On your marks!

adamralph commented 9 years ago

Thanks @aarondandy!

Sorry it took so long to get this one in.

aarondandy commented 9 years ago

That's fine, just been wasting my life on videogames lately anyway.