search

adamralph / bau

The C# task runner
MIT License
152 stars 17 forks source link

Test output directory #209

Open eatdrinksleepcode opened 9 years ago

eatdrinksleepcode commented 9 years ago

f9e39b4 changed all of the test tasks in the build to output their results to "artifacts/tests". However, less than a month later, e48aaee added dogfooding of the XUnit plugin to the build, but in doing so reverted all of the test tasks to output to their own bin directory. However, the "artifacts/tests" directory is still created during the build. We should either fix the tests to output to "artifacts/tests", or remove all references to that directory from the build.

adamralph commented 9 years ago

Well spotted. The reversion actually happened a later commit - https://github.com/bau-build/bau/commit/780bb643bd8ec16aab1daa7cc3f1add31084ef3f

What do you think? Trash the directory or redirect the tests? Simplest is to trash the directory.

eatdrinksleepcode commented 9 years ago

I'm on the fence. All of the build systems that I have used default to putting build artifacts in a project-specific directory. However, CoreFX overrides this and puts all artifacts in a common directory at the root. I can some advantage to that; project-specific output directories are often at the bottom of a deep directory hierarchy, and it would be simpler to access the artifacts if they were at the top. On the other hand, if I am working with a particular project, needing to go back up the hierarchy to access the build artifacts could be awkward.

I guess I lean towards putting everything in the common root directory, but mostly just so I can get more experience with that model and formulate an opinion about it, which is not a particularly good reason. Beyond that I don't have a strong opinion.

adamralph commented 9 years ago

I don't mind either way. If you fancy picking this up then just go with whatever your mood suggests. If I were to pick it up that's what I'd do :wink:.