search

adamralph / minver

🏷 Minimalistic versioning using Git tags.
Apache License 2.0
848 stars 59 forks source link

Support Revision Part of version number #962

Closed Juff-Ma closed 9 months ago

Juff-Ma commented 9 months ago

Pull request for #961

One test couldn't complete for me because of a weird error with the nupkg being put in the wrong folder. One still can't run (seemingly because of the same issue). Another one is impossible for me to run (DoesNotRecreatePackage) because my system language is set to german.

All other test run fine for me. (Please ignore the double and coauthored commit, this is an error caused by visual studio git support)

adamralph commented 9 months ago

@Juff-Ma one important thing to bear in mind is that the experience for consumers who are using SemVer (3 part) versions should be unaffected by this change. This spike seems to assume that only NuGet (4 part) versions are used and it appears to force that on to all consumers.

Juff-Ma commented 9 months ago

@Juff-Ma one important thing to bear in mind is that the experience for consumers who are using SemVer (3 part) versions should be unaffected by this change. This spike seems to assume that only NuGet (4 part) versions are used and it appears to force that on to all consumers.

The only thing it changes currently is the default version for auto increment but i think this could be changed to Patch by default again if required. I added tests (left some old ones intact) to make sure that 3-part tags would still work.

If someone was to use the tag "v1.2.3" and auto-increment Patch it should only change the logging output now printing 1.2.3.0/1.2.4.0 this seems to be possible because minver/nugetversion by default doesn't assume what version format you use but i could be wrong

adamralph commented 9 months ago

@Juff-Ma thanks for providing the spike.

I get the feeling it would have to be controlled by an option, e.g. <MinVerFourPartVersion>true</MinVerFourPartVersion> to ensure that the default behaviour does not mention a four part version anywhere—not even in the logs—otherwise it could be quite confusing. This likely means maintaining two code paths—one for three part versions and one for four part versions, which seems non-trivial.

Moreover, I'm not sure the use case is common enough to make this worthwhile. It seems that three part versions are canonical. The System packages all seem to use three part versions and in the first few pages of the most popular packages, only the AWS SDK packages use a four part version.

Given the above, I'm not sure it makes sense add this feature.

Juff-Ma commented 9 months ago

@Juff-Ma thanks for providing the spike.

I get the feeling it would have to be controlled by an option, e.g. <MinVerFourPartVersion>true</MinVerFourPartVersion> to ensure that the default behaviour does not mention a four part version anywhere—not even in the logs—otherwise it could be quite confusing. This likely means maintaining two code paths—one for three part versions and one for four part versions, which seems non-trivial.

Moreover, I'm not sure the use case is common enough to make this worthwhile. It seems that three part versions are canonical. The System packages all seem to use three part versions and in the first few pages of the most popular packages, only the AWS SDK packages use a four part version.

Given the above, I'm not sure it makes sense add this feature.

That makes sense. The use cases i have are pretty niche and even i don't have them all the time. While it would have been cool to have this included it isn't a requirement even for me. I get that having to maintain two code paths for such a niche functionality is unacceptable. I personally also use SemVer when applicable and therefore also MinVer when available .