Versions pefixed with v are parsed even in strict mode

adamreeve / semver.net

Semantic versioning for .NET

MIT License

117 stars 22 forks source link

Versions pefixed with v are parsed even in strict mode #57

Closed anatawa12 closed 1 year ago

anatawa12 commented 1 year ago

Is “v1.2.3” a semantic version?

No, “v1.2.3” is not a semantic version.

I think it should not parsed in strict mode.

https://dotnetfiddle.net/QtKY6r

adamreeve commented 1 year ago

Hi, yes you're right this probably should not have been allowed in strict mode. This library generally aims to be compatible with the node semver package, which allows a leading "v", but that also allows a leading "=" which we only allow in loose mode, so our behaviour is already a bit different. I think it makes sense to include this in the next major version release.