lukehb
commented
3 years ago Capturing the conversation from the old issue tracker:
Z. Why specifically version 85 rather than the current one, M88?
A. We need git commit hashes for our build process and so far we have found that the easiest way to get them is through the WebRTC change log which only lists M85 as the latest. If you know of a better way to find them we would be happy to switch.
Z. For some reason they've stopped updating that page, but the release notes for newer versions are still available here and link to the branch. https://groups.google.com/g/discuss-webrtc/c/A0FjOcTW2c0/m/UAv-veyPCAAJ Chrome 88 became the stable version fairly recently.
A. Thanks for the intel we will look at that version instead for the update.
Z. One thing that particularly stands out there is this comment:
RTP Datachannels are going away As of M88, use of RTP datachannels will cause a deprecation warning. We expect to remove them altogether in M90
Z. If I'm understanding the code correctly, Pixel Streaming currently uses RTP channels. Does that mean, if not upgraded before the release of Chrome 90, it will just... stop working?
L. We have done some research and asked our contacts, the removal of RTP data channels is a non-issue for Pixel Streaming. Pixel Streaming is using SCTP for data channels, which will remain well supported across browsers. RTP will remain a supported transport for video/audio - so no problems there either. According to our research, RTP data channels were never widely adopted anyway, so their removal is not too surprising as it turns out.
dai-martov
sasmaster
adamrehn
wurrego
adrian-j-programmer
This issue is ported from our old issue tracker for public visibility.
Currently we link against a version of WebRTC that is slightly further ahead than release 70 (from what we can tell this is the version that the binaries that Setup.sh provides). Upgrading to a newer version will give us all the enhancements that has come in the 15 or so versions since.
We have made some progress on this with version 85 however it require significant changes to the current way we build WebRTC and how the Pixel Streaming plugin interacts with it. Any updates to this will be posted here and any outside insights would be appreciated.
Additionally, there is also a bug with Pixel Streaming where stream resolution drops, video quality degrades, and stream quality never recovers to the original (despite network connection being fine). There is some hope that upgrading WebRTC will resolve this; however, we cannot say for sure it will. Regardless, an upgrade of WebRTC brings other benefits to Pixel Streaming.
Note to ourselves (or anyone external who wants to attempt the WebRTC upgrade):
Engine/Source/ThirdParty/WebRTC/{YouRev}.If you are targeting M88, our current progress on upgrading to M88 is in the 4.25-webrtc-exp (note, it is broken currently).
Note: We know Pixel Streaming is using parts of the WebRTC API that have changed from M70 to M88, so we already know it won't compile.