Closed slonopotamus closed 1 year ago
Suggested fix: add missing SetupMono.sh
call. But be careful with 4.26+: https://github.com/EpicGames/UnrealEngine/commit/54437183ba91c305c2b8cfe0574e29b1e83be2d8#diff-a4b6f4db17a499341d06e2ffcdf8d0e0ef2b94f89ab545f1ddc15ca0e9fa0388L59-R60
Yes, adding the call for SetupMono.sh fixes the problem. The error of xbuild: command not found
does not occur anymore.
@slonopotamus I reckon the most appropriate place for this would be in patch-broken-releases.py, since it's where we currently implement version-specific patching logic.
I am actually not sure that ad-hoc strings replacement in random engine files is a good idea in a long-term. A kinda better solution would be to just keep those changes in UE fork. We should not try to fix each and every engine bug and such approach (with a fork) makes it much easier to see which changes are relevant to what engine versions.
Given that we're going to drop 4.20 support (https://github.com/adamrehn/ue4-docker/issues/296#issuecomment-1451285462) and there is a workaround (patch your engine fork), I want to close this as WONTFIX.
Output of the
ue4-docker info
command:Additional details:
Way to reproduce:
ue4-docker build 4.20.3 --no-engine --exclude ddc --exclude debug --exclude templates
ue4-docker test 4.20.3
Expected: test passes
Actual:
Initial analysis:
Setup.sh
, but we only run that in ue4-source.RunUAT.sh
in 4.20 is missing a call toSetupMono.sh
that was added in 4.21, so it doesn't use bundled version of Mono