search

adamreisnz / replace-in-file

A simple utility to quickly replace contents in one or more files
580 stars 65 forks source link

[fix] Enable `glob` `windowsPathsNoEscape` option to fix `v7` usage on Windows #169

Closed hakimio closed 11 months ago

hakimio commented 1 year ago

Fixes broken v7 usage on Windows OS when nodejs path.join() is used to create file paths.

More info: #165

Also:

hakimio commented 1 year ago

@adamreisnz can you take a look?

adamreisnz commented 11 months ago

Had another look at this one. Is there a reason why you cannot just provide windowsPathsNoEscape via the glob configuration option then? If that's what's needed to fix it, you can specify that in the config and there is no need to have it checked/set in this package.

I've updated the Readme to reflect that: https://github.com/adamreisnz/replace-in-file#specify-glob-configuration

However, for the CLI this will not be available, but it could be added behind a new CLI flag. If you want to modify this PR to implement that I will merge that in.