search

adamreisnz / replace-in-file

A simple utility to quickly replace contents in one or more files
580 stars 65 forks source link

Export 'replaceInFile' namespace. #173

Closed kukko closed 11 months ago

kukko commented 12 months ago

I fixed the issue, so the replaceInFile namespace wasn't exported.

I reported this issue in the #172 issue.

kukko commented 12 months ago

Would you be so kind and participate with the repository in Hacktoberfest, so it would count as one of my PRs for the event?

adamreisnz commented 12 months ago

Sure, how do I do that? Should I wait with merging this PR until I have joined?

kukko commented 12 months ago

The site of Hacktoberfest states the following: Add the “hacktoberfest” topic to your repository to opt-in to Hacktoberfest and indicate you’re looking for contributions.

But you can simply merge the PR if you think it is okay. Hacktoberfest now don't give nice rewards, so it isn't necessary for me. But even without it I would create this PR.

Do you think that the PR is acceptable and necessary?

lornz commented 11 months ago

Definitely necessary for me! Otherwise it fails on build. This PR fixes that.

Would be great if you could merge it.

adamreisnz commented 11 months ago

Thank you, have merged it in

adamreisnz commented 11 months ago

Has been released as 7.0.2