adamritter / nostr-relaypool-ts

A Nostr RelayPool implementation in TypeScript using only nostr-tools library as a dependency
https://www.npmjs.com/package/nostr-relaypool
MIT License
63 stars 17 forks source link

Set kind to 2 or update Event type #38

Closed agustinkassis closed 1 year ago

adamritter commented 1 year ago

Hi Augustin,

I'm not sure what this change is about, but kind 2 is generally not used by relays, because it contains only 1 relay. 10003 is a ,,hack'' on wss://us.rbr.bio and wss://eu.rbr.bio that serves write relays until 10002 is used everywhere, similarly to Pablo's server (purple nostr or something like that).

I'm planning to talk to him about using the same kind for this purpose, and of course transitioning to 10002 should be a priority.

moogmodular commented 1 year ago

Cant build because of this.

image

adamritter commented 1 year ago

:( I understand now

Does // @ts-ignore help?

On Wed, Apr 12, 2023, 01:06 moogmodular @.***> wrote:

Cant build because of this.

[image: image] https://user-images.githubusercontent.com/1299858/231378693-bda5294c-a761-4606-9be3-b29ec9ce1e59.png

— Reply to this email directly, view it on GitHub https://github.com/adamritter/nostr-relaypool-ts/pull/38#issuecomment-1504773137, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5SWAF3GD5K7LGWKDT64K3XAZIADANCNFSM6AAAAAAWZTKLC4 . You are receiving this because you commented.Message ID: @.***>

moogmodular commented 1 year ago

:( I understand now Does // @ts-ignore help?

You mean by monkey patching? Im using it as a library. skipLibCheck and excluding node_modules didn't help either. Rolling back to 0.6.7 for now.

adamritter commented 1 year ago

No, I'll merge it of course and release. Meanwhile of course you can use yarn link if you use yarn anyways :)

On Wed, Apr 12, 2023, 01:33 moogmodular @.***> wrote:

:( I understand now Does // @ts-ignore https://github.com/ts-ignore help?

You mean by monkey patching? Im using it as a library. skipLibCheck and excluding node_modules didn't help either. Rolling back to 0.6.7 for now.

— Reply to this email directly, view it on GitHub https://github.com/adamritter/nostr-relaypool-ts/pull/38#issuecomment-1504802527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5SWACQ62MDZNBBDPGQ22LXAZLD5ANCNFSM6AAAAAAWZTKLC4 . You are receiving this because you commented.Message ID: @.***>

adamritter commented 1 year ago

I added @ts-ignore and released a new npm.

Can you please verify that it builds for you?

On Wed, Apr 12, 2023 at 1:36 AM Adam Ritter @.***> wrote:

No, I'll merge it of course and release. Meanwhile of course you can use yarn link if you use yarn anyways :)

On Wed, Apr 12, 2023, 01:33 moogmodular @.***> wrote:

:( I understand now Does // @ts-ignore https://github.com/ts-ignore help?

You mean by monkey patching? Im using it as a library. skipLibCheck and excluding node_modules didn't help either. Rolling back to 0.6.7 for now.

— Reply to this email directly, view it on GitHub https://github.com/adamritter/nostr-relaypool-ts/pull/38#issuecomment-1504802527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5SWACQ62MDZNBBDPGQ22LXAZLD5ANCNFSM6AAAAAAWZTKLC4 . You are receiving this because you commented.Message ID: @.***>

agustinkassis commented 1 year ago

Im sorry, I included the lib dir in the pull request, as I had in my own repo.

nostr-tools should include that kind.

moogmodular commented 1 year ago

Can you please verify that it builds for you?

0.6.16 builds now, thanks