Improve build automation

adams85 / acornima

Acornima is a standard-compliant JavaScript parser for .NET. It is a fork of Esprima.NET combined with the .NET port of the acornjs parser.

BSD 3-Clause "New" or "Revised" License

9 stars 3 forks source link

Improve build automation #3

Closed lahma closed 4 months ago

lahma commented 4 months ago

fix workflow definitions (this repo uses master instead of main, pr worfklow should track PRs and build workflow pushes/tags)
add minimal .gitattributes (fixes build.sh)
fix Acornima.sln
exclude macOS from recursion testing

After changing GitHub definitions for NUKE, I needed to run build.cmd to generate new YAML files, that's the procedure for such changes.

adams85 commented 4 months ago

Thanks for the fixes! BTW, how about this: https://github.com/adams85/acornima/pull/2#discussion_r1490209180

lahma commented 4 months ago

Thanks for the fixes! BTW, how about this: #2 (comment)

Good catch, fixed the logic and removed some redundancy. Not sure how the actual version will determined, was just a template, one possibility is GitVersion tasks and automation.