adamsardar / stoneTrees

Integrating 'omics data with biological networks by solving Steiner Tree problems
Mozilla Public License 2.0
3 stars 3 forks source link

bugs and minor changes #8

Closed JulieBorgel closed 4 years ago

JulieBorgel commented 5 years ago

This PR should fix 3 main bugs and highlight other issues which haven't been treated yet

Resolved issues

Solver time limit

suboptimal solutions

resampling within Steiner Forest

Remaining issues

RGLPK on Windows

Glpk on windows is under-performing compare to the latest version of glpk on linux and OSX. This is most probably because of RGLPK on windows. It looks like that an older version of glpk comes packaged with RGLPK and I couldn't find a way to force RGLPK to use the latest version of glpk on windows.

RCPLEX or cplexAPI

Rcplex doesn't compile with the latest version of CPLEX. For that reason, using cplexAPI would probably be better but the tests for the solver interoperability might need to be improved.

adamsardar commented 4 years ago

Thanks Julie - a great eye for detail, in particular the bootstrap sampling case. Maybe well be followed up in #13