search

adamschwartz / log

Console.log with style.
https://adamschwartz.co/log
MIT License
3.01k stars 140 forks source link

Amended Pull Request #14

Closed craniumslows closed 10 years ago

craniumslows commented 11 years ago

I changed it up to use the more greedy .* and that will match anything inside of reference which is what we want anyway.

Apologies for making a little mess. Confirmed it works with FF and Chrome isn't happy with WebKit Nightly

craniumslows commented 11 years ago

Let me know if I'm failing at this. :facepunch:

adamschwartz commented 11 years ago

Hey @craniumslows, thanks for all of your help so far. I'd like to merge these changes, particularly the parts which address #11 and #12. However, I'm seeing several issues when I test locally in Chrome 27.0.1453.93 on Mac OS. (See the screenshot below.)

If you can address these regressions I'd be happy to merge.

Also, note that the clear trick seems to be triggering an infinite recursive call.

log

craniumslows commented 11 years ago

Hi

​Sorry about that ill be able to fix this late Sunday or early Monday. Thanks for emailing / messaging me! 

-craniumslows 

— Sent from Mailbox for iPhone

On Wed, Jun 5, 2013 at 7:56 PM, Adam Schwartz notifications@github.com wrote:

Hey @craniumslows, thanks for all of your help so far. I'd like to merge these changes, particularly the parts which address #11 and #12. However, I'm seeing several issues when I test locally in Chrome 27.0.1453.93 on Mac OS. (See the screenshot below.) If you can address these regressions I'd be happy to merge. Also, note that the clear trick seems to be triggering an infinite recursive call.

log

Reply to this email directly or view it on GitHub: https://github.com/adamschwartz/log/pull/14#issuecomment-19019010