search

adamsilverstein / modern-images-wp

Apache License 2.0
81 stars 7 forks source link

Possible conflict with customizer -> site icon #27

Open scofennell opened 2 years ago

scofennell commented 2 years ago

Hi, see screenshot where I'm getting a console error when I provide a png favicon in the customizer.

Uncaught TypeError: Cannot read properties of undefined (reading 'site_icon-32')

The end result is that it fails to apply the new icon, and also it seems to generate a weird blank image in the media library.

I'm not sure what to make of this, but it seems like a bit of a roadblock. If I remove the plugin, I can upload and pick my favicon just fine. And of course, if I config the plugin to no longer convert png's, it works fine as well.

If the image_editor_output_format exposed more information about the image and the current screen, I might be able to conditional my way out of this. As it is now, I'm not sure what a good workaround would be.

Screen Shot 2021-11-22 at 3 36 39 PM
adamsilverstein commented 2 years ago

@scofennell thanks for the bug report. do you have the plugin set to change PNG to WebP (in settings)? Can you provide the PNG image you are using in your case and I will try to reproduce.

scofennell commented 2 years ago

Yes, I do have it set to change png to webp. I was able to repro with any arbitrary png. Here's one:

favicon-1