search

adamsoffer / next-apollo

React higher-order component for integrating Apollo Client with Next.js
MIT License
481 stars 64 forks source link

migrate to apollo-boost #38

Closed ascott1 closed 5 years ago

ascott1 commented 5 years ago

👋 @adamsoffer. Thanks for this great package. I'm teaching React/Next & GraphQL and find the use of this package to be much easier for students to understand than the HOC in the official next examples.

This should address #23 by migrating from the deprecated apollo-client-preset to apollo-boost.

adamsoffer commented 5 years ago

Thanks @ascott1. Appreciate the kind words and great knowing this will help your students.

PR looks great. Merging now.

p.s. I'm from New Haven as well 🙌

ascott1 commented 5 years ago

p.s. I'm from New Haven as well 🙌

Small world! I'm currently using this library when building out the web app for my next O'Reilly book. I would love to chat sometime.

ascott1 commented 5 years ago

@adamsoffer I thought this was a simple 1:1 dependency swap, but it looks like it causes issues with all of the example implementations. I haven't had a chance to dig in too much, but my theory is that it's caused by apollo-boost's different configuration options.

In the meantime it might be better to roll this back and look at importing the packages individually, rather than via boost. Sorry!!!

adamsoffer commented 5 years ago

Seems like this is actually a bug in apollo-boost. I downgraded and froze the apollo-boost dep to 0.3.1 and confirmed it works with the next-apollo-example now :) Thanks again.

Small world! I'm currently using this library when building out the web app for my next O'Reilly book. I would love to chat sometime.

That book looks awesome! Would love to chat. You should come through the Digital Surgeons office sometime at District :) My email is adam @ soffer dot dev

ascott1 commented 5 years ago

Ah, good catch!