search

adamsoffer / next-apollo

React higher-order component for integrating Apollo Client with Next.js
MIT License
482 stars 64 forks source link

Update implementation to use AppTree #51

Closed bwesner closed 5 years ago

bwesner commented 5 years ago

In your next-apollo-example, you mention waiting on a bug fix to be able to use useRouter properly: https://github.com/adamsoffer/next-apollo-example/blob/52317222c6a326568056ffa1ed63793fa423d10d/components/Header/index.js#L7

They have fixed it in https://github.com/zeit/next.js/pull/7732

We need to update next-apollo to use AppTree so that this can be properly supported. Afterwords, next-apollo-example should be updated.

Check out how they updated their example here: https://github.com/zeit/next.js/commit/dc9e2708984bc6bc7e87724fb5193e7f788c89a3

adamsoffer commented 5 years ago

Great thanks for the heads up @bwesner.

adamsoffer commented 5 years ago

@bwesner Sorry been quite busy and haven't gotten to this yet. Feel free to submit a PR!

adamsoffer commented 5 years ago

@bwesner heads up this has been fixed in v3.1.4