Closed ecklf closed 3 years ago
Wow thanks @impulse ! This looks great. I'm on vacation at the moment but I'll get try and review and test this ASAP.
Hey @impulse. This looks great. Regarding your questions...
It seems there is no toJSON() method. Is this still relevant for apollo client v3?
Not sure TBH
It seems ssrMode cannot be accessed from an ApolloClient instance?
Your solution LGTM
Maybe someone knows how to address this type error.
Not sure about this one either.
I'm good to merge this and publish whenever you address the above. Thanks again for this epic PR.
@adamsoffer I think we can merge this for now in the scope of converting things to TypeScript. I don't want to introduce anything breaking, so I guess it would be better to work out and extensively test the things I've mentioned in future PRs.
Thanx guys!
closes #71
Before merging I would like to talk about the following lines that needed type overwrites:
1) https://github.com/impulse/next-apollo/blob/master/src/withApollo.tsx#L58 It seems there is no
toJSON()
method. Is this still relevant for apollo client v3?2) https://github.com/impulse/next-apollo/blob/master/src/withApollo.tsx#L220 It seems
ssrMode
cannot be accessed from an ApolloClient instance? Wouldn't it be the better solution to do:3) https://github.com/impulse/next-apollo/blob/master/src/withApollo.tsx#L182 Maybe someone knows how to address this type error.
Result in VSCode: