search

adamsol / Pyxell

Multi-paradigm programming language compiled to C++, written in Python.
MIT License
54 stars 6 forks source link

Added GitHub Actions for testing #11

Closed ThatXliner closed 3 years ago

adamsol commented 3 years ago

Nice, thank you!

Since there is testing against different Python versions, could you also add testing against GCC in addition to Clang?

python test.py -c=gcc

Sometimes the two compilers behave differently, so it would be handy to have them both tested automatically.

I can see the action properly run in your fork (https://github.com/ThatXliner/Pyxell/actions/runs/539085397), but the job name is "build". Shouldn't it be "test"?

Also, I'm wondering how the failed tests would be displayed. It's probably necessary to add some non-zero exit code in test.py.

ThatXliner commented 3 years ago

Maybe I should name the entire file name to CI and that specific job "test"

ThatXliner commented 3 years ago

So I updated it here: https://github.com/ThatXliner/Pyxell/actions/runs/541236964

Also, I'm wondering how the failed tests would be displayed. It's probably necessary to add some non-zero exit code in test.py.

yes, definitely

adamsol commented 3 years ago

Could you also add that change in test.py? It should be as simple as:

if failed:
    sys.exit(1)

And it would be great to see that the Github action turns red when a test fails. So maybe change some test output and commit it to a temporary branch. When it works, the PR will be ready to merge :-)

ThatXliner commented 3 years ago

Got it

adamsol commented 3 years ago

Thanks!

Now I don't know why this has failed, I'll need to investigate. It's probably something wrong with the test script, since the failed tests are not displayed in the output.

adamsol commented 3 years ago

I hope to have fixed that in 1f9e1f572822f21b46d895299bde490a1eab32c0.