adamspd / django-appointment

A Django app for managing appointment scheduling with ease and flexibility.
Apache License 2.0
149 stars 41 forks source link

Be able to disable email verification when booking an appointment #173

Closed SDeVuyst closed 5 months ago

SDeVuyst commented 6 months ago

Feature Description

When booking an appointment, the client is required to enter their email and confirm with an auth code. In some use cases this is unnecessary.

The Ideal Solution

An option so the email verification code step can be skipped, and the client goes straight to the thank-you/payment page. Maybe even an option that does not require the client to enter their email at all.

Priority

How important is this feature to you?

adamspd commented 6 months ago

Hello @SDeVuyst,

Could you clarify what you meant by "in some use cases, this is unnecessary"? I'm interested in understanding the specific scenarios you're referring to, purely for my own learning and knowledge.

Also, would you be available to assist with or contribute to a pull request incorporating the changes you mentioned? If that's not possible for you at the moment, I'll take the initiative to implement them myself in a later release.

Thank you for your input and assistance.

SDeVuyst commented 6 months ago

Hi, thanks for your quick response.

My use case is a local pediatrician. They would prefer that their patients don't even need to input any email adress, so an email with an auth code is a definite no. I know this is vulnerable for spamming, but they are ok with this.

I will take a look to implement this myself, but no promises as I am pretty busy for the moment.

Thanks

adamspd commented 6 months ago

Before you begin working on the implementation, could you inform me? I aim to avoid overlapping efforts. I'm currently addressing some other issues, but plan to focus on this next. It would be great to exchange ideas if you've started coding by then.

SDeVuyst commented 6 months ago

I can actually start working on this the 4th of april already. I don't think this will be too much of a hassle to implement (watch this backfire on me...) How do you suggest we move forward? - and are there any guidelines you want me to follow? I think I would rather implement a system so you will be able to book without an email adress, rather than disabling the verification. This fits my use case more

adamspd commented 6 months ago

Sorry it took me so long to reply. Well, you can start the pull request, and I can revise from there. But I'm not sure that it's easy, I mean the logic in the code, yes, but there may be a few functions that need tweaking. To start with, I'd say you need to add a variable to settings.py that will determine whether you want email to be mandatory or not, and based on that, remove the email field from the forms and modify the functions mentioned.

SDeVuyst commented 5 months ago

Hi! Apologies for this, but I do not need this feature anymore. Customer changed their mind :). Thanks anyways! Cheers