adamspd / django-appointment

A Django app for managing appointment scheduling with ease and flexibility.
Apache License 2.0
87 stars 29 forks source link

When client enter only firstname is not handled well #189

Closed adamspd closed 1 month ago

adamspd commented 1 month ago

Describe the bug Environment:

Request Method: POST
Request URL: https://django-appt.adamspierredavid.com/appointment/client-info/1/17156424663544787568680320b4c4db4ba6968fe20a52242/

Django Version: 5.0.6
Python Version: 3.11.9
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'main_app',
 'appointment']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'main_app.middlewares.RestrictAdminAccessMiddleware']

Traceback (most recent call last):
  File "/home/ubuntu/web/django_appt_web/env/lib/python3.11/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/web/django_appt_web/env/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/web/django_appt_web/env/lib/python3.11/site-packages/appointment/views.py", line 350, in appointment_client_information
    user = create_new_user(client_data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/web/django_appt_web/env/lib/python3.11/site-packages/appointment/utils/db_helpers.py", line 274, in create_new_user
    client_data['first_name'], client_data['last_name'] = parse_name(client_data['name'])
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Exception Type: ValueError at /appointment/client-info/1/17156424663544787568680320b4c4db4ba6968fe20a52242/
Exception Value: not enough values to unpack (expected 2, got 1)

To Reproduce Steps to reproduce the behavior:

  1. Choose date and time
  2. When asking for full name, enter one word

Expected behavior Handle that better when only firstname is entered (to work).