search

adamsutton / tvheadend

Tvheadend is a TV streaming server for Linux supporting DVB-S, DVB-S2, DVB-C, DVB-T, ATSC, IPTV, and Analog video (V4L) as input sources.
http://www.lonelycoder.com/hts/tvheadend_overview.html
Other
19 stars 5 forks source link

Move satconfig into tv adapters config #69

Closed clandmeter closed 11 years ago

clandmeter commented 11 years ago

Would it be possible to move the current satconfig into tv adapters tree? When somebody selects a tv adapter, one could set the LNB type and the switch type. After setting the correct switch, it would create 4 children in the adapter tree which would be the 4 switch ports. Each switch port could be selected and enabled/disabled and provided with a proper name (for instance satellite name/position). When you provide a name and enable the switch port, this would automatically create a network in the network tab. The network name could be a combination of switch name and adapter number ie 1:Astra 19.2E or whatever sounds logical. This could probably be done that same way for other DVB devices, removing the need to create a network manually. One would of course still need to edit it to set the correct settings.

amet commented 11 years ago

@adamsutton no comments here? :)

adamsutton commented 11 years ago

WTF! That's twice now I've commented on this issue only to find the comments have not been published!

adamsutton commented 11 years ago

@amet I did put a comment on (twice) to say the original intention was to put satconf structures into the HW tree. Problem is its a complete nightmare from an implementation point of view, not least because of the completely illogical way DVB-S works.

However as always, if someone fancies doing a better job, PRs welcome ;)

adamsutton commented 11 years ago

Just to illustrate the issue, you've selected the 2nd simplest setup (the simplest being those of us that have no switch and just an LNB, probably universal).

You can't assume that the next thing after teh switch will be an LNB (and thus network). There could be a rotor and then LNB. Though that in itself is a PITA, since physically the LNB comes after the rotor and in some respects that makes sense, except ofc each rotor position will use the same LNB (because its the same dish).

And what about users with uncomitted switches? Connected to those could be:

and ofc from a practical (implementation point of view) to keep the code from being horrible (not that its not already) a satconf is actually just a proxy for the frontend it serves, so you have to make sure you deal with that (if you need to, maybe you don't).

amet commented 11 years ago

I didn't think any of the settings should go, simply moving satconf setup page where adapters are for simplicity.

now, we go into adapters and enable, "tick" and thats it, why not add all other satconf settings in there? same c/p settings that are in satconf page.

I am not sure if that is whats currently possible in code, but the way I see it is, adapter is only connected to a switch/rotor -> another switch/LNB and that never changes(at least not daily).... bottom line, there is only one way you can setup satconf for given adapter HW configuration, why have option to set another one? .. satconf is extension of adapter setting and having it separate is confusing to say the least.

I know we had this conversation before, but I still feel that it should be squashed into one page :) ... feel free to ignore ...

adamsutton commented 11 years ago

If you can knock something up that works and covers all bases I'll take a look. I guess for me the issue is balancing what makes sense from a technical point of view, with (and this is more important) what I can managed in the UI (where my skills are not good).

clandmeter commented 11 years ago

Amet and I had a chat to discuss how we (from a user’s view) look at it. Currently we have the satconfigs tab which holds a grid which lists each separate satconfig on each line. Let’s first define what a satconfig is: A satconfig is the way how an LNB is connected to an adapter. Currently there are four ways defined:

  1. Single LNB
  2. A single LNB connected to switch on a particular port number
  3. A single LNB attached to a rotor on a particular position
  4. A single LNB attached to a rotor on a particular position which is connected to a switch on a particular port number.

What we would like to do is remove the satconfigs page and move the items from the grid into the TV adapter tree. When one goes to the deepest level in the adapter tree (frontend level) there is a dialog on the right which has a list of options. Just below the Keep “FE open” we could add a button called “Add satellite config” Or maybe “Add LNB configuration”. This button would open a dialog similar like the dialog we use now for “Add satconfig” (we could just reuse the current code). When we save this config we add an item too the tree of this particular frontend (see fig1). The name of this item is the name of the satconfig. In this setup we would lose the way of modifying the satconfig as we do in the grid, but we can just select the satconfig and edit its settings in the right dialog (similar like we do for the frontend).

Fig1: https://dl.dropboxusercontent.com/u/18871200/new_satconfig_design.png

adamsutton commented 11 years ago

This is now considered done.