adamtabrams / change

A simple tool that automates generating and updating a changelog
GNU General Public License v3.0
78 stars 8 forks source link

Extra '.' added when one exists in subject. #18

Closed jguiditta closed 3 years ago

jguiditta commented 3 years ago

Description Extra '.' added when one exists in subject.

Expectation If the subject line of a commit ends with '.', an additional one should not be added.

Replication Explain how to recreate the bug.

  1. Add a commit that ends with '.'
  2. run 'change'
  3. See the new entry in changelog ends with '..'

Environment

Further Explanation Aside from this, the tool is quite handy and easy to use!

adamtabrams commented 3 years ago

@jguiditta Thanks for posting an issue! It's great to hear that this is a useful tool for you! I just pushed a new release that only adds a period to the end of the commit message if punctuation (specifically . ? or !) doesn't already exist. Can you verify that this update fixed the bug?

jguiditta commented 3 years ago

I just tested, and it seems to have fixed the issue! Thanks so much for the quick turnaround on that.

adamtabrams commented 3 years ago

related changes: https://github.com/adamtabrams/change/commit/3d6ea23b2ff718162db50ffe9b05fcf45d774827