search

adamtool / webinterface

The web interface for the tool Adam (AdamMC and AdamSYNT) providing an intuitive, visual definition of Petri nets with transits and Petri games, and an interactive interface to the algorithms of AdamMC and AdamSYNT. Contains the repos (as submodules): libs, framework, logics, modelchecking, examples, synthesizer, high-level, webinterface-backend.
http://adam.informatik.uni-oldenburg.de:4567/
GNU General Public License v3.0
5 stars 2 forks source link

The coordinates of a previously created Petri net are reused for nodes with the same id. #4

Closed mgieseking closed 4 years ago

mgieseking commented 4 years ago

The easiest way to reproduce the error:

1) load via "File -> Load APT from file" a file with coordinates 2) use the auto layout function 3) load the same file again.

You don't get the coordinates saved in the file, but the previous locations. This is the same if you just create a new Petri net and then use a node with an id of the previous Petri net.

annyanich commented 4 years ago

What APT file and browser have you tried this with? I just followed your steps with "ATVA19_motivatingExample.apt" on Firefox 79 / Chromium 83 and couldn't reproduce it. (it could be a race condition that just doesn't occur on my setup.)

mgieseking commented 4 years ago

I tested it in Firefox and Chromium with this file:

SR_R2_T2_P2_ohnePartition.txt

annyanich commented 4 years ago

Ok. I realized I was using "load example" and not "load APT from file." Sorry about that. I tried it again and I found that in Chromium, reloading the file indeed did not work as intended -- I had to first load a different file before I could reload the original file. I think I have fixed that bug in 57ecb3803f067e9b9ebb1c3530e5860f4787793e.

I have not been able to replicate it in Firefox 79 or 80 (I am on 80, the newest, now), though. Can you see if I fixed the issue with this new version?

mgieseking commented 4 years ago

Thanks, seems to work for me too (also in Firefox).