adamtool / webinterface

The web interface for the tool Adam (AdamMC and AdamSYNT) providing an intuitive, visual definition of Petri nets with transits and Petri games, and an interactive interface to the algorithms of AdamMC and AdamSYNT. Contains the repos (as submodules): libs, framework, logics, modelchecking, examples, synthesizer, high-level, webinterface-backend.
http://adam.informatik.uni-oldenburg.de:4567/
GNU General Public License v3.0
5 stars 2 forks source link

APT files without coordinates cause visualization problems #98

Open mgieseking opened 3 years ago

mgieseking commented 3 years ago

When loading an APT file without coordinates and then going to the graphical editor, the physics control does not effect the nodes and they are all collapsed. The auto layout is not adding the coordinates to the nodes (only the switch to the text editor does this).

So solving the net, creates errors due to missing coordinates (this is my problem and I'll fix this). But the visualization would also be nice to have fixed, but since no one should use APT files without coordinates anymore, since everyone uses this web interface to create Petri game/nets with transits. This is not really a problem ;P

annyanich commented 3 years ago

Ah, yes, I noticed this one too (the nodes all bunched together) and forgot to put an issue for it. I think it is a one-line fix, just have to bump the "alpha" (aka temperature) of the physics simulation when the new net is loaded.

annyanich commented 3 years ago

Another issue is that the 'zoom to fit all nodes' does not occur if the graph editor is not open, because it relies on checking the size in pixels of the svg element.

annyanich commented 3 years ago

As a workaround, would it be acceptable to forcibly switch to the Petri Game / PNWT tab when a new example is loaded?

annyanich commented 3 years ago

In 951dfb26d84d18ba7ce5f6335deea5d31641dde0 I added the fix for examples without coordinates