adamucho / assignment-7

0 stars 0 forks source link

Feedback on assignment #7 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #7 Project: Responsive Design


Description

Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.

Student: Adam Cho

Project URL: https://github.com/adamucho/assignment-7

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use media queries at a 768px breakpoint x
Content remains in appropriate divs x
Content remains visible to the user x
Fonts change size appropriately x
Margins and padding change size appropriately x
Content does not overlap x
In the blog section, the two-column layout changes to a single-column layout when appropriate x
TOTAL: 13/14
barryross commented 7 years ago

Adam, great work on this! You are doing some great things here and very cool to see you using rems in your media query. Overall, you are meeting the requirements at the 768px breakpoint. I left a mark off for the margin/padding requirement because I think there some places (such as the attached) where giving the content more space would be appropriate. Overall, great work though and please see inline comments for additional info. 👍

screen shot 2017-02-20 at 1 54 55 pm

barryross commented 7 years ago

I do think if you were to build on this, a good next step/challenge would be to try and ensure that the above requirements are met as you adjust the size of the window. So, far example, content remains visible even at 900px or so. This wasn't part of the requirement for the assignment, but a good next step. It would be in an effort to eliminate stuff like this: screen shot 2017-02-20 at 1 50 30 pm