adamwaite / iOS-Build-Kit

☠️ BuildKit is a modular command line interface for automating iOS project builds. Bundled build tasks include: Increment app version • Xcode build • Overlay version number on icon files • Run unit tests • Create .ipa artefact.
MIT License
568 stars 54 forks source link

-lPods not found issue in example project #13

Closed delebedev closed 10 years ago

delebedev commented 10 years ago

Struggling from this issue for the whole day. Console output is library not found for -lPods During debugging i've discovered that the bug appears because buildkit produces CONFIGURATION_BUILD_DIR="Builds" option for xctool and somehow Pods project does not take it into acccount. Trying to find the solution, any help is appreciated

nemesis commented 10 years ago

Do you reference the workspace when building?

delebedev commented 10 years ago

IMMEDIATE UPDATE: it happens because buildkit expects full path in :build_dir setting. Working on solution

delebedev commented 10 years ago

@nemesis sure I do :)

delebedev commented 10 years ago

Actually, I see use cases when :build_dir and other preferences can be both relative and absolute paths, so buildkit config should determine that and expand path to full if necessary (and leave 'as is' if it's already expanded). Builds -> users/src/project/Builds users/src/project/Builds -> users/src/project/Builds @adamwaite what do you think? Should this pattern be applied to all options?

adamwaite commented 10 years ago

That would be great actually. Not sure how you might go about checking if the path is relative or absolute though? Unless you try finding relative and if it fails, try absolute, and if that also fails raise an exception? Can't think of a cleaner way to do it off the top of my head. I'm all for this though. Appreciate the help on this. Make a 'Contributors' section in the README and put yourself on there!

delebedev commented 10 years ago

If path starts with / its defenitely absolute one otherwise it's relative. So basically workflow remains the same, but TaskRunnerConfig returns correct version of path and assertions work like before.

adamwaite commented 10 years ago

Haha of course, I think I need to go back to bed! Yes, that works.

adamwaite commented 10 years ago

Fixed with https://github.com/adamwaite/iOS-Build-Kit/pull/14