search

adamwaite / iOS-Build-Kit

☠️ BuildKit is a modular command line interface for automating iOS project builds. Bundled build tasks include: Increment app version • Xcode build • Overlay version number on icon files • Run unit tests • Create .ipa artefact.
MIT License
568 stars 54 forks source link

Unspecified code_sign_arg #26

Closed Kudo closed 9 years ago

Kudo commented 10 years ago

Hi,

I try to build my app project with iOS-Build-Kit. I have one issue for signing an IPA. Checking the code at https://github.com/adamwaite/iOS-Build-Kit/blob/master/lib/ios_build_kit/tasks/create_ipa.rb#L69 code_sign configuration is set to code_sign_arg. However, code_sign_args does not being use at https://github.com/adamwaite/iOS-Build-Kit/blob/master/lib/ios_build_kit/tasks/create_ipa.rb#L71

In my environment, without specified the sign, the generated IPA will have old provision information. I guess my Xcode's provisions are outdated, but I want to update my provisions handy without Xcode.

Are there any reasons for not specifying the sign in xcrun?

adamwaite commented 10 years ago

That's a good point. I'm not sure how I missed that. Let me work on it.

adamwaite commented 9 years ago

Hey @Kudo. This should be sorted now. Only took me 7 months. I'll get on to your PR soon, thanks!

Kudo commented 9 years ago

Thanks @adamwaite.

After a little testing, I found there are still some code sign inconsistency between xcrun and xcodebuild. For example, I use my developer provision in xcode, then during xcodebuild step, it will sign with the developer provision implicitly. If later for xcrun code sign step, I give another different provision, when upload to app store, they will complain for inconsistency. My workaround is to do code sign in xcodebuild step but not xcrun step. One limitation for xcodebuild is that it only accept provision included in Xcode, i.e. Before build, we should refresh Xcode's provisions handy.

BTW, there are still some other changes from me, but the design is totally different from your, so I did not send PR for you. Here are they and you may able to have some reference and I am likely to see if the changes can be merge in mainstream.

Thank you.