search

adamwathan / form

Super basic form HTML builder, only really exists so I can pull it in for some other more useful projects.
MIT License
232 stars 117 forks source link

datetime-local support #104

Closed AydinHassan closed 8 years ago

AydinHassan commented 8 years ago

Hi, I added datetime-local element, hope it is up to standard! PR for bootforms coming soon also.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.8%) to 93.81% when pulling c63297f15738109407f99c683709ea9a823a79c9 on AydinHassan:datetime-local-support into 8056cea6743de85e079d69bc43ee8e358553a9a7 on adamwathan:master.

AydinHassan commented 8 years ago

hey @adamwathan any chance to get a look at this & https://github.com/adamwathan/bootforms/pull/114 ?

adamwathan commented 8 years ago

Hey @AydinHassan sorry for the delay!

Can you add test coverage for the stuff that sets the value and does the date formatting? I don't see anything in the tests for that functionality yet.

Thanks!

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 94.762% when pulling 54be9582d36e7b53b667d2a18b5bdc0f7b7f718d on AydinHassan:datetime-local-support into 8056cea6743de85e079d69bc43ee8e358553a9a7 on adamwathan:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 94.762% when pulling 54be9582d36e7b53b667d2a18b5bdc0f7b7f718d on AydinHassan:datetime-local-support into 8056cea6743de85e079d69bc43ee8e358553a9a7 on adamwathan:master.

AydinHassan commented 8 years ago

@adamwathan that better? 😄

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 94.762% when pulling 93524cfd28ac6d1fce0d9c8b71f6ebc13ee6c662 on AydinHassan:datetime-local-support into 8056cea6743de85e079d69bc43ee8e358553a9a7 on adamwathan:master.