adamwathan / form

Super basic form HTML builder, only really exists so I can pull it in for some other more useful projects.
MIT License
232 stars 117 forks source link

Form namespaces #109

Open jesseleite opened 7 years ago

jesseleite commented 7 years ago

Adds form namespaces. Usage example:

Form::name('profile')->open()
    Form::bind($bindProfileInputs)
    // Form inputs
Form::close()

Form::name('survey')->open()
    Form::bind($bindSurveyInputs)
    // Form inputs
Form::close()

If both forms have an explicit namespace, when you submit one form, the other form's bound input will be left alone (rather than checking old input on both forms).

axyr commented 7 years ago

Why not Form::open()->name('myformname') ?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 94.241% when pulling 52c25ba84ed042a59c9c9c6b8963e95ee06c204e on JesseLeite:form-namespaces into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

jesseleite commented 7 years ago

@axyr I had Form::open()->namespace() in my first two commits, but we needed to store the namespace on the builder instance. Adam suggested it be implemented at the builder level, similar to Form::bind() for that reason.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.06%) to 94.7% when pulling 1da702822fba20cff1e318db4f8578541b8cda21 on JesseLeite:form-namespaces into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

jesseleite commented 7 years ago

@adamwathan @axyr Updated implementation to accept name() before open() 👍 Example...

Form::name('profile')->open()
    Form::bind($bindProfileInputs)
    // Form inputs
Form::close()
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 94.344% when pulling b349416fc58f587166380094c6ff72787ff46d16 on JesseLeite:form-namespaces into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 94.286% when pulling 6daf1ce7de3fb2691eab529877bdb10859cb919f on JesseLeite:form-namespaces into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 95.0% when pulling 3b30df46b5917b3393311c37345b066ca2e2842c on JesseLeite:form-namespaces into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 95.089% when pulling 33513e131aac850e4f582788eeb38e71e8043bfc on JesseLeite:form-namespaces into cc5c2b650d6e1174b7c3000e2643585676e416a8 on adamwathan:master.