search

adamwathan / form

Super basic form HTML builder, only really exists so I can pull it in for some other more useful projects.
MIT License
232 stars 118 forks source link

No error message with input named with brackets #35

Closed sdebacker closed 9 years ago

sdebacker commented 9 years ago

We have this input:

<input type="text" name="customer[name]">

and this corresponding validation rule:

$rules = [
    'customer.name' => 'required',
];

If empty input is submitted, we should have an error, but no error or message was set.

sdebacker commented 9 years ago

Added issue #37

adamwathan commented 9 years ago

Awesome this looks great, thanks! Could you add a test for the case you outlined in the initial comment? I can add it too if you don't have time. Will get it merged in then :+1:

adamwathan commented 9 years ago

Added your commits to this PR on a new branch, with comments there: #38

sdebacker commented 9 years ago

Hello Adam,

If you have the time, can you write the test ? I have little experience with testing and little time for the moment.

Samuel

Le 18 févr. 2015 à 19:43, Adam Wathan notifications@github.com a écrit :

Awesome this looks great, thanks! Could you add a test for the case you outlined in the initial comment? I can add it too if you don't have time. Will get it merged in then

— Reply to this email directly or view it on GitHub.