search

adamwathan / form

Super basic form HTML builder, only really exists so I can pull it in for some other more useful projects.
MIT License
232 stars 117 forks source link

Remove transformKey() from IlluminateOldInputProvider? #88

Closed jesseleite closed 8 years ago

jesseleite commented 8 years ago

We were running transformKey() on old input twice, which is a problem (see issue #87).

Existing tests pass, but we have no actual IlluminateOldInputProvider test coverage, instead it's mocked everywhere.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-10.9%) to 83.871% when pulling 9ac1d61d972fd72c9e3910a1a2785f5b3e04798d on JesseLeite:bugfix-double-key-transform into 89b19934a2d3e95b6261ad7e6f6c6055973b56d9 on adamwathan:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.7%) to 95.526% when pulling 401549c5fda572a1da9afbaa4740827d3d5fc077 on JesseLeite:bugfix-double-key-transform into 89b19934a2d3e95b6261ad7e6f6c6055973b56d9 on adamwathan:master.

jesseleite commented 8 years ago

Nevermind, bad idea.