Closed sdebacker closed 8 years ago
Looking at the Translatable Bootforms package to try and understand how this is being used in case there's a better solution, where is this translate()
method defined? Is it expecting that you only bind models that implement the translate
method?
Also I think I would rather just add a data
method like in the other package instead of making the first param optional in get
. If you can make that change I'll merge this no biggie.
The translate method is here : https://github.com/dimsav/laravel-translatable/blob/master/src/Translatable/Translatable.php
I just created a data method. Thank you.
After the version bumping, I will make a PR on Propaganistas’ package.
Hello Adam, do you plan to release a v0.8.8 version that include this new data() method?
Whoops, sorry! Done!
Nice & Thanks.
Hello Adam,
I propose this small change to make it possible to get data object. With this feature, we no longer have to make a child class of BoundData in https://github.com/Propaganistas/Laravel-Translatable-Bootforms package.