search

adamwathan / form

Super basic form HTML builder, only really exists so I can pull it in for some other more useful projects.
MIT License
232 stars 117 forks source link

Unnecessary array_filter? #97

Closed jesseleite closed 8 years ago

jesseleite commented 8 years ago

I found an issue where array_filter in BoundData is causing binding issues with simple array elements where key is 0 (zero). This PR adds a failing test to prove the issue, and suggests removal of that array_filter call. Do you see any issue with this?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.647% when pulling 71d17cac8b1a72d7348ac196718e233f20f4623e on JesseLeite:bugfix-unnecessary-array-filter into 942f10721bedd6c8d52da9fdfa5633ddf272548e on adamwathan:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.647% when pulling 1cd183f77e44736df7cbfb0ccb8bda7a6fedf530 on JesseLeite:bugfix-unnecessary-array-filter into 942f10721bedd6c8d52da9fdfa5633ddf272548e on adamwathan:master.

adamwathan commented 8 years ago

Seems fine :)

jesseleite commented 8 years ago

Thanks man.