numbers1311407
commented
12 years ago Seems possibly futile since this is a 2 year old issue, but I strongly second this. Rush is really cool, but the way it clutters up Array is just messy and error prone.
I ran into a real-life case of this just now on a Rails 3 project on Heroku. The method_missing implementation of ActiveRecord::Relation looks to methods defined on Array first before scopes, meaning that, for example, Rush:Commands#search would short circuit an ActiveRecord scope of the same name.
The result was the evocation of a few "What the hell??" exclamations when I started seeing errors complaining about my class not responding to dir? in the Heroku logs. It was only then that I realized Heroku was including Rush and mixing all kinds of methods into Array.
A Rush::FileArray or something would be a great thing, as opposed to the assumption that all Arrays in the app are lists of files.
trans
scytacki
Hi, I'm looking at using Rush for on my projects, and if I do I would like to contribute back to Rush, as I will need many more commands than Rush currently defines.
I need to look into it a bit more, but I do see one issue I would want to see addressed, that is the extension of the Array class. There is the potential here for conflicts with the built-in Array methods and other people's Array extensions (of which I use quite a few). A more robust approach would be to use a subclass of Array, for the sake of discussion, let's call it FileArray. The Rush methods would return a Rush::FileArray instead of an Array where applicable. A single method can be added to Array to convert a regular array to a FileArray, perhaps #files or #to_files.