search

adamws / kicad-git

Git actions directly from KiCad's PCB editor window
GNU General Public License v3.0
17 stars 1 forks source link

Requires 'git citool' to be present. #1

Closed Gasman2014 closed 4 months ago

Gasman2014 commented 4 months ago

Thank you for producing this plugin. On macOS (at least), I found that the tool fails silently and doesn't bring up the commit window. It looks like there is an expectation for git citool to be available and this requires git-gui tools to be installed.

I think it would be helpful to mention this in the README.

It is easily accomplished on macOS with a brew install git-gui. Running git citool from the command line will then bring up the necessary window.

However, there is a further problem on macOS as KiCad uses its own bundled python binary and NOT the system binary. Calling the system python will result in import failures as the system python cannot import pcbnew. I think wx might also be a problem unless installed specifically in the system python.

adamws commented 4 months ago

I added info about git-gui installation to README

I don't have access to macOS, on Windows KiCad also uses own bundled python and it works as expected