adamws / kicad-git

Git actions directly from KiCad's PCB editor window
GNU General Public License v3.0
17 stars 1 forks source link

KiCAD 8.0.1: Commits are not sent to GitHub #4

Closed tormyvancool closed 2 months ago

tormyvancool commented 2 months ago

The pluginopens the interface. But when I commit changes, fo GIT is regularly done while changes are NOT sent to GitHub. Indeed when I go on GitHub to check if everything is ok, it isn't.

NOTE: why doesn't the plugin show up on the Schematic page? image

adamws commented 2 months ago

1) if you want to upload to remote you need to push (and not just commit) 2) plugins are limited to pcbnew, this is how KiCad does it

tormyvancool commented 2 months ago
  1. if you want to upload to remote you need to push (and not just commit)
  2. plugins are limited to pcbnew, this is how KiCad does it

I can't commit without staging After have stgaged I can commit. It turn itself off If I restart it, there is nothing

If it was working how it should I had not to open an issue here.

Here the animated GIF KiCAD_Commit

image

adamws commented 2 months ago

kicad-git is just a launcher of git gui (https://git-scm.com/docs/git-gui)

adamws commented 2 months ago

I noticed that there is an difference when started as: git citool (this is what this plugin calls) - top git gui - bottom image see difference in menus. This might be related. You can try to change config https://github.com/adamws/kicad-git?tab=readme-ov-file#configuration to something like:

[paths]
git = git.exe
git_gui = git.exe gui
tormyvancool commented 2 months ago

kicad-git is just a launcher of git gui (https://git-scm.com/docs/git-gui)

When I do use the GIT GUI (that I have been using from years now), that doesn't come with KiCAD: it works as it should. When I use GIT on KiCAD what's occurring is what I posted: it doesn't work (at least on my system)

Here below with GIT GUI image

and here the uploaded file. image

As I said: by using the KiCAD plugin: it doesn't work :-/

adamws commented 2 months ago

did you tried changing config? apparently git citool / git gui citool does not behave same as git gui

tormyvancool commented 2 months ago

did you tried changing config? apparently git citool / git gui citool does not behave same as git gui

So the GIT GUI external one (not in KiCAD) a syou saw it works. For the "config.ini" you asked for: I have made it but it didn't change any behavior

tormyvancool commented 2 months ago

Version 0.3 issue solved. It Commits and pushes.