adamws / kicad-kbplacer

KiCad plugin for automatic keyboard's key placement and routing
GNU General Public License v3.0
333 stars 23 forks source link

Place additional components per-switch #3

Closed cgarcia2097 closed 1 year ago

cgarcia2097 commented 1 year ago

My older codebase, that has fallen in disrepair, is able to place components other than diodes around the switch. Would you be able to implement that feature in this plugin?

adamws commented 1 year ago

you can do it already. Run plugin twice, for second run place first component next to switch, check Use first switch-diode pair as reference for relative position and modify Diode annotation format string to match new components. This way your other components will be handled just like diodes. Dedicated interface for this (which would work in single plugin run) might be added in some future release but it is not on top of my priority list.

cgarcia2097 commented 1 year ago

Understood. That being said, are you accepting pull requests? I could try patching it in. I had mine set up as a wxTable where the prefixes are added dynamically by the user.

ReFil commented 1 year ago

This would be a really handy feature for placing per switch LEDs alongside switch and diode

adamws commented 1 year ago

This would be a really handy feature for placing per switch LEDs alongside switch and diode

This feature will be part of next release and it currently developed on https://github.com/adamws/kicad-kbplacer/tree/place-additional-elements branch.

This feature has been merged to master and is available in https://github.com/adamws/kicad-kbplacer/releases/tag/v0.5 (pre-release - not yet available with KiCad's PCM but this should happen soon)