search

adamwulf / JotUI

OpenGL based drawing view built for and used by Loose Leaf for iPad
http://getlooseleaf.com/opensource/
MIT License
268 stars 28 forks source link

failed to make complete framebuffer object 8cd6 #17

Closed sosolo0307 closed 7 years ago

sosolo0307 commented 7 years ago

Thank you for creating a really good library.

I made a big size view.(2,300, 1800) However, the following situation has occurred : How can I solve this problem?

adamwulf commented 7 years ago

is that resolution in pts or px? I've tested up to the px size of the iPad Pro (2732 x 2048px, 1368 x 1024pt). I suspect you're above the max allowed texture size for the device, which I believe is around 2048 pts)

sosolo0307 commented 7 years ago

You're right. I did not know the max allowed texture size for the device. That the maximum size of texture is 2048. When I think of the size, I realize that the size of texture is too big for me, so how should I handle it? And is there a way to make a larger Canvas using a bunch of smaller texture?

adamwulf commented 7 years ago

There are two options that I can think of. The first would be to create a 2nd JotView and layout next to the first. This'll be tricky to handle drawing strokes that cross that boundary, but theoretically is possible.

The second option would be to create a JotView with the correct width/height ratio, then use a transform to scale the JotView's texture to the correct visible size. This would be much much easier to implement, but would mean slightly lower resolution on export.

sosolo0307 commented 7 years ago

Thank you for your kind reply. I thought you'd do it as well as you told me. Of course I'm not convinced of myself, but I'm more confident when I hear your words. I think the first method would be much better than the second one. I guess there's a lot of work to do, but I think it's worth challenging.

The first method didn't seem to be able to produce prototypes quickly, so I tried to test them in the second way. Moreover, the performance was worse than expected, and the quality was poor. Of course I can't make it because I can't make it, but I want to improve it. I'll try to make lots of attempts.

Of course I still don't understand your code.I'll try to understand it quickly. Thank you !

adamwulf commented 7 years ago

good luck and lmk what you end up with! i'll close out this issue, but feel free to open another as questions arise