adamwulf / loose-leaf

Intuitive note taking app. Import and annotate PDFs, manipulate imported photos with intuitive gestures, and take notes with Apple Pencil.
https://getlooseleaf.com
MIT License
620 stars 95 forks source link

Printing issues with scraps via AirPrint #892

Closed heatherwong closed 9 years ago

heatherwong commented 9 years ago

Printed a few pages via Share > Print

Issue 1: some scraps printed out blank even though all scraps is visible on page (Update: scrap is blank in list view) Issue 2: printed page scrap not aligned same as seen in page.

tested in build 0.9.1 iPad 2 iOS 7.1.1

adamwulf commented 9 years ago

for the scraps that printed out blank, did they also show fine in list view? in theory the same content that's shown in list view is whats sent to the printer. i'll give test this when i get home tonight too

heatherwong commented 9 years ago

Scrap didn't show in list view so I guess that printed as expected.

Sent from my iPhone

On Oct 7, 2014, at 1:46 PM, Adam Wulf notifications@github.com wrote:

for the scraps that printed out blank, did they also show fine in list view? in theory the same content that's shown in list view is whats sent to the printer. i'll give test this when i get home tonight too

— Reply to this email directly or view it on GitHub.

adamwulf commented 9 years ago

was the scrap completely gone in list view, or was it the same bug as scraps showing up but blank?

On Tue, Oct 7, 2014 at 3:57 PM, heatherwong notifications@github.com wrote:

Scrap didn't show in list view so I guess that printed as expected.

Sent from my iPhone

On Oct 7, 2014, at 1:46 PM, Adam Wulf notifications@github.com wrote:

for the scraps that printed out blank, did they also show fine in list view? in theory the same content that's shown in list view is whats sent to the printer. i'll give test this when i get home tonight too

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/adamwulf/loose-leaf/issues/892#issuecomment-58260605.

heatherwong commented 9 years ago

Scrap was there but rotated in different angle. Separate issue

Sent from my iPhone

On Oct 7, 2014, at 2:29 PM, Adam Wulf notifications@github.com wrote:

was the scrap completely gone in list view, or was it the same bug as scraps showing up but blank?

On Tue, Oct 7, 2014 at 3:57 PM, heatherwong notifications@github.com wrote:

Scrap didn't show in list view so I guess that printed as expected.

Sent from my iPhone

On Oct 7, 2014, at 1:46 PM, Adam Wulf notifications@github.com wrote:

for the scraps that printed out blank, did they also show fine in list view? in theory the same content that's shown in list view is whats sent to the printer. i'll give test this when i get home tonight too

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/adamwulf/loose-leaf/issues/892#issuecomment-58260605.

— Reply to this email directly or view it on GitHub.

adamwulf commented 9 years ago

my test prints are looking fine - i think the scrap issues are separate from printing. as long as its printing the same thing as shows in list view, it should be good to go. i couldn't repro any scrap/rotation/blank issues. the fixes from #863 and #829