Closed proski closed 1 year ago
can tweak makefile.pl to optionally remove from generated Makefiles
I can imagine some cases where redirects to NUL would be needed.
Instead, we should probably consider setting SHELL=cmd.exe
in every Makefile. It would ensure consistent behavior regardless of whether sh.exe
is present in PATH.
hi, preferred solution: https://github.com/adamyg/mcwin32/commit/af3b37b8069c861a495273d8a6b73de3e6118463 VERBOSE=1 option
OK, I'm closing this PR. The issue with NUL
creation can be addressed by using SHELL=cmd.exe
. Some messages can be quieted with VERBOSE
. Other messages should not be quieted. For instance, if cp.exe
is missing, I want to know it right away rather than figure out why a header is missing. But that more about the overuse of -
(ignore) in the makefiles than about verbosity.
thx for the input.
Hiding output makes it harder to troubleshoot problems with the build system.
When
sh.exe
is present in PATH, files named NUL are created in the source directories. They are problematic to remove.