adamyg / mcwin32

Midnight Commander for Windows
https://sourceforge.net/projects/mcwin32/
204 stars 13 forks source link

Don't redirect output to /dev/null or NUL in makefiles #41

Closed proski closed 1 year ago

proski commented 1 year ago

Hiding output makes it harder to troubleshoot problems with the build system.

When sh.exe is present in PATH, files named NUL are created in the source directories. They are problematic to remove.

adamyg commented 1 year ago

can tweak makefile.pl to optionally remove from generated Makefiles

proski commented 1 year ago

I can imagine some cases where redirects to NUL would be needed. Instead, we should probably consider setting SHELL=cmd.exe in every Makefile. It would ensure consistent behavior regardless of whether sh.exe is present in PATH.

adamyg commented 1 year ago

hi, preferred solution: https://github.com/adamyg/mcwin32/commit/af3b37b8069c861a495273d8a6b73de3e6118463 VERBOSE=1 option

proski commented 1 year ago

OK, I'm closing this PR. The issue with NUL creation can be addressed by using SHELL=cmd.exe. Some messages can be quieted with VERBOSE. Other messages should not be quieted. For instance, if cp.exe is missing, I want to know it right away rather than figure out why a header is missing. But that more about the overuse of - (ignore) in the makefiles than about verbosity.

adamyg commented 1 year ago

thx for the input.