search

adamzalesak / PV286-Project

Data converter between different formats written in C# (collaborative university project)
0 stars 0 forks source link

Misconfigured project #16

Closed Pa3u3u closed 1 year ago

Pa3u3u commented 1 year ago

Running the program with no arguments says

$ dotnet run
Input file 'C:\Users\filip.hajek\Desktop\test.txt' was not found

That should probably not happen.

filiphajek commented 1 year ago

Yes, it's because of launchSettings.json file. This file should be ignored by .gitignore .. we use it to debug/test our app. It should not be really versioned since it is basically local developer settings.

Pa3u3u commented 1 year ago

There is no rule for this file in .gitignore. The following commits added or modified it:

commit ba679eed3db342d938abc04b75b6e612fc0a5f3b
Author: Filip Hájek <filip.hajek@notino.com>
Date:   Sat Mar 18 16:27:08 2023 +0100

    byte format validations

commit 0423ad12a92f8be39e8422bfb16f3e2ff22c4962
Author: Filip Hájek <filip.hajek@notino.com>
Date:   Thu Mar 16 02:44:14 2023 +0100

    delimeter as string - init

commit 6d058afe097b226e042873dc73c1dddb3ebf6b43
Author: Filip Hájek <filip.hajek@notino.com>
Date:   Tue Mar 14 01:07:59 2023 +0100

    base convertor, intergration tests

The offending line was added in commit ba679eed.

filiphajek commented 1 year ago

Sorry, yesterday I forgot to ignore it in the .gitignore file .. there is now open PR https://github.com/adamzalesak/PV286-Project/pull/24 for this issue.